From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 0B4B230508 for ; Thu, 6 Jun 2019 10:07:49 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 8ELkLoorc0IJ for ; Thu, 6 Jun 2019 10:07:48 -0400 (EDT) Received: from smtp59.i.mail.ru (smtp59.i.mail.ru [217.69.128.39]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id BBEC52CA22 for ; Thu, 6 Jun 2019 10:07:48 -0400 (EDT) Date: Thu, 6 Jun 2019 17:07:46 +0300 From: Kirill Yukhin Subject: [tarantool-patches] Re: [PATCH v1 1/1] sql: move space existence check to VDBE Message-ID: <20190606140746.f6mbjurtbyrjmahq@tarantool.org> References: <08ea8b249e2d04ec819a2e5bd9487619fcf87a4c.1557334891.git.imeevma@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <08ea8b249e2d04ec819a2e5bd9487619fcf87a4c.1557334891.git.imeevma@gmail.com> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: tarantool-patches@freelists.org Cc: korablev@tarantool.org Hello, On 08 May 20:02, imeevma@tarantool.org wrote: > Before this patch, the existence of space was checked for the > CREATE TABLE or CREATE VIEW statements during the parsing. If the > space already exists, an error has been set and cleanup is > performed. But, if the statement contained 'IF NOT EXIST', the > cleanup was performed, but the error was not set. This causes an > error when creating a foreign key during space creation. > > This patch moves this check to VDBE. Thus, the parsing should now > be properly closed before performing this check. > > Closes #4196 > --- > https://github.com/tarantool/tarantool/issues/4196 > https://github.com/tarantool/tarantool/tree/imeevma/gh-4196-move-space-existence-check-to-vdbe I've checked your patch into 2.1 and master. -- Regards, Kirill Yukhin