From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Thu, 6 Jun 2019 14:58:05 +0300 From: Vladimir Davydov Subject: Re: [tarantool-patches] Re: [PATCH 04/10] vinyl: rework vylog transaction backlog implementation Message-ID: <20190606115805.hzwa627beconnqko@esperanza> References: <8f65d06127e605e1ab41a24f984fec816c2d23cc.1558103547.git.vdavydov.dev@gmail.com> <20190601083838.GE29429@atlas> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190601083838.GE29429@atlas> To: Konstantin Osipov Cc: tarantool-patches@freelists.org List-ID: On Sat, Jun 01, 2019 at 11:38:38AM +0300, Konstantin Osipov wrote: > * Vladimir Davydov [19/05/17 17:54]: > > I like this approach, I would push it regardless of other patches. > The patch is LGTM. I'm afraid I can't push it without the previous patch. You see, I need to flush the xlog buffer before loading vylog. I can't call xlog_flush from vy_recovery_new unless it's running in the same thread as vylog writer, because xlog struct shouldn't be used from different threads. But without the previous patch vy_recovery_new runs in coio, not WAL.