From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <vdavydov.dev@gmail.com>
Date: Wed, 5 Jun 2019 20:28:50 +0300
From: Vladimir Davydov <vdavydov.dev@gmail.com>
Subject: Re: [tarantool-patches] Re: [PATCH 2/2] net.box: fetch '_vcollation'
 sysview into the module
Message-ID: <20190605172850.rrapakadshzxjnjo@esperanza>
References: <cover.1559219194.git.roman.habibov@tarantool.org>
 <8580960460ba5013b81e3a327fc94df2377c06da.1559219194.git.roman.habibov@tarantool.org>
 <20190604163603.ukdr3qogig5leksl@esperanza>
 <2F4F2E2A-9C27-42B2-94D8-98513D1398A9@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <2F4F2E2A-9C27-42B2-94D8-98513D1398A9@tarantool.org>
To: Roman Khabibov <roman.habibov@tarantool.org>
Cc: tarantool-patches@freelists.org
List-ID: <tarantool-patches.dev.tarantool.org>

On Wed, Jun 05, 2019 at 08:08:39PM +0300, Roman Khabibov wrote:
> 
> > On Jun 4, 2019, at 7:36 PM, Vladimir Davydov <vdavydov.dev@gmail.com> wrote:
> > 
> > On Thu, May 30, 2019 at 03:36:03PM +0300, Roman Khabibov wrote:
> >> Fetch "_vcollation" sysview to show collation name instead collation id.
> >> 
> >> Closes #3941
> >> ---
> >> src/box/lua/net_box.lua  | 24 ++++++++++++++++++------
> >> test/box/net.box.result  |  2 +-
> >> test/box/stat_net.result |  4 ++--
> >> 3 files changed, 21 insertions(+), 9 deletions(-)
> > 
> > This one looks good to me, but you probably need to write a doc bot
> > request.
> > 
> What should I write in this request? I understood, that you meant
> info about _vcollation existance.

Yep, something like this I suppose:

  https://www.tarantool.io/en/doc/2.1/book/box/box_space/#box-space-vspace

BTW we miss _vsequence documentation. Should be added as well.