From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tarantool-patches-bounce@freelists.org>
Received: from localhost (localhost [127.0.0.1])
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 10D232FA0B
	for <tarantool-patches@freelists.org>; Wed,  5 Jun 2019 08:07:51 -0400 (EDT)
Received: from turing.freelists.org ([127.0.0.1])
	by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id MJ-4_UV80Kvm for <tarantool-patches@freelists.org>;
	Wed,  5 Jun 2019 08:07:50 -0400 (EDT)
Received: from smtp54.i.mail.ru (smtp54.i.mail.ru [217.69.128.34])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 875222FA47
	for <tarantool-patches@freelists.org>; Wed,  5 Jun 2019 08:07:50 -0400 (EDT)
Date: Wed, 5 Jun 2019 09:52:09 +0300
From: Konstantin Osipov <kostja@tarantool.org>
Subject: [tarantool-patches] Re: [PATCH 2/5] swim: fix a 'use after free' in SWIM tests
Message-ID: <20190605065209.GC28736@atlas>
References: <cover.1559433539.git.v.shpilevoy@tarantool.org>
 <4cefb872a2caa773601da067ff3dd4fb872967c5.1559433539.git.v.shpilevoy@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4cefb872a2caa773601da067ff3dd4fb872967c5.1559433539.git.v.shpilevoy@tarantool.org>
Sender: tarantool-patches-bounce@freelists.org
Errors-to: tarantool-patches-bounce@freelists.org
Reply-To: tarantool-patches@freelists.org
List-Help: <mailto:ecartis@freelists.org?Subject=help>
List-Unsubscribe: <mailto:tarantool-patches-request@freelists.org?Subject=unsubscribe>
List-software: Ecartis version 1.0.0
List-Id: tarantool-patches <tarantool-patches.freelists.org>
List-Subscribe: <mailto:tarantool-patches-request@freelists.org?Subject=subscribe>
List-Owner: <mailto:>
List-post: <mailto:tarantool-patches@freelists.org>
List-Archive: <http://www.freelists.org/archives/tarantool-patches>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tarantool-patches@freelists.org

* Vladislav Shpilevoy <v.shpilevoy@tarantool.org> [19/06/03 14:33]:

LGTM.

>  test/unit/swim_test_transport.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/test/unit/swim_test_transport.c b/test/unit/swim_test_transport.c
> index c4a1dd774..334ac926e 100644
> --- a/test/unit/swim_test_transport.c
> +++ b/test/unit/swim_test_transport.c
> @@ -85,6 +85,7 @@ swim_test_packet_new(const char *data, int size, const struct sockaddr_in *src,
>  static inline void
>  swim_test_packet_delete(struct swim_test_packet *p)
>  {
> +	rlist_del_entry(p, in_queue);
>  	free(p);
>  }
>  
> -- 
> 2.20.1 (Apple Git-117)
> 

-- 
Konstantin Osipov, Moscow, Russia