From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Mon, 3 Jun 2019 19:14:01 +0300 From: Vladimir Davydov Subject: Re: [tarantool-patches] [PATCH v1 3/8] schema: rework _func system space format Message-ID: <20190603161401.di5rvoftgearajym@esperanza> References: <20190530120626.GA16142@atlas> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190530120626.GA16142@atlas> To: Konstantin Osipov Cc: tarantool-patches@freelists.org, Kirill Shcherbatov List-ID: On Thu, May 30, 2019 at 03:06:26PM +0300, Konstantin Osipov wrote: > * Kirill Shcherbatov [19/05/30 14:12]: > > This patch updates a _func system space to prepare it for > > working with persistent functions. The format of the _func > > system space is > > [ UINT, UINT, STR, UINT, > > Why is setuid uint? > > > STR, STR, STR, > > BOOL] > > Shouldn't you add 'options' to the format right away, to make life > easier? +1 I'd also move is_deterministic to 'options', because it is an option per se.