From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tarantool-patches-bounce@freelists.org>
Received: from localhost (localhost [127.0.0.1])
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 6EC072E7A7
	for <tarantool-patches@freelists.org>; Mon,  3 Jun 2019 07:54:16 -0400 (EDT)
Received: from turing.freelists.org ([127.0.0.1])
	by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id 3bZ3s-j13UN6 for <tarantool-patches@freelists.org>;
	Mon,  3 Jun 2019 07:54:16 -0400 (EDT)
Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 2A6B12E77E
	for <tarantool-patches@freelists.org>; Mon,  3 Jun 2019 07:54:16 -0400 (EDT)
Date: Mon, 3 Jun 2019 14:54:13 +0300
From: Mergen Imeev <imeevma@tarantool.org>
Subject: [tarantool-patches] Re: [PATCH v1 8/9] sql: use diag_set() to set an
 error in SQL functions
Message-ID: <20190603115412.GB24317@tarantool.org>
References: <cover.1559043251.git.imeevma@gmail.com>
 <f973f83e60cf1467a6d0fbfc7adf044510f5c2b5.1559043252.git.imeevma@gmail.com>
 <309b47d5-55ca-1d7f-4f96-98021a48ada7@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <309b47d5-55ca-1d7f-4f96-98021a48ada7@tarantool.org>
Sender: tarantool-patches-bounce@freelists.org
Errors-to: tarantool-patches-bounce@freelists.org
Reply-To: tarantool-patches@freelists.org
List-Help: <mailto:ecartis@freelists.org?Subject=help>
List-Unsubscribe: <mailto:tarantool-patches-request@freelists.org?Subject=unsubscribe>
List-software: Ecartis version 1.0.0
List-Id: tarantool-patches <tarantool-patches.freelists.org>
List-Subscribe: <mailto:tarantool-patches-request@freelists.org?Subject=subscribe>
List-Owner: <mailto:>
List-post: <mailto:tarantool-patches@freelists.org>
List-Archive: <http://www.freelists.org/archives/tarantool-patches>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tarantool-patches@freelists.org

On Sun, Jun 02, 2019 at 06:35:08PM +0200, Vladislav Shpilevoy wrote:
> 
> > diff --git a/src/box/sql/vdbeapi.c b/src/box/sql/vdbeapi.c
> > index 597d37e..673ccd1 100644
> > --- a/src/box/sql/vdbeapi.c
> > +++ b/src/box/sql/vdbeapi.c
> > @@ -762,75 +724,6 @@ sql_aggregate_context(sql_context * p, int nByte)
> > -/*
> > - * Set the auxiliary data pointer and delete function, for the iArg'th
> > - * argument to the user-function defined by pCtx. Any previous value is
> > - * deleted by calling the delete function specified when it was set.
> > - */
> > -void
> > -sql_set_auxdata(sql_context * pCtx,
> > -		    int iArg, void *pAux, void (*xDelete) (void *)
> > -    )
> 
> Still is mentioned in a couple of comments.
Fixed.