From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 2A13730664 for ; Sat, 1 Jun 2019 05:16:31 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id wQuDeC8DaK4M for ; Sat, 1 Jun 2019 05:16:30 -0400 (EDT) Received: from smtp34.i.mail.ru (smtp34.i.mail.ru [94.100.177.94]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 6B8CB30656 for ; Sat, 1 Jun 2019 05:16:30 -0400 (EDT) Received: by smtp34.i.mail.ru with esmtpa (envelope-from ) id 1hX07o-00089h-IE for tarantool-patches@freelists.org; Sat, 01 Jun 2019 12:16:28 +0300 Date: Sat, 1 Jun 2019 11:41:42 +0300 From: Konstantin Osipov Subject: [tarantool-patches] Re: [PATCH 09/10] key_def: pass alloc callback to key_def_dump_parts Message-ID: <20190601084142.GG29429@atlas> References: <20190518185231.GE9448@atlas> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190518185231.GE9448@atlas> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: tarantool-patches@freelists.org * Konstantin Osipov [19/05/18 21:56]: > * Vladimir Davydov [19/05/17 17:54]: > > So that we can use an allocator different from the region in vylog. > > Please, let's simply always use malloc. > > btw, sql code is shit. not a single comment for entire call trace > of key_def_dump_parts() from there. I failed to understand whether > this is a hot path or not. I stand by this request. -- Konstantin Osipov, Moscow, Russia