From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id D1B7B30659 for ; Sat, 1 Jun 2019 05:16:31 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id e1kGq1A2YAWI for ; Sat, 1 Jun 2019 05:16:31 -0400 (EDT) Received: from smtp54.i.mail.ru (smtp54.i.mail.ru [217.69.128.34]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 9B79E3065D for ; Sat, 1 Jun 2019 05:16:30 -0400 (EDT) Received: by smtp54.i.mail.ru with esmtpa (envelope-from ) id 1hX07o-00023d-8c for tarantool-patches@freelists.org; Sat, 01 Jun 2019 12:16:28 +0300 Date: Sat, 1 Jun 2019 11:36:00 +0300 From: Konstantin Osipov Subject: [tarantool-patches] Re: [PATCH 03/10] vinyl: move vylog recovery to vylog thread Message-ID: <20190601083600.GD29429@atlas> References: <69dfb6ed09c655e842ae9200598fce9c62176998.1558103547.git.vdavydov.dev@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <69dfb6ed09c655e842ae9200598fce9c62176998.1558103547.git.vdavydov.dev@gmail.com> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: tarantool-patches@freelists.org * Vladimir Davydov [19/05/17 17:54]: > We used coio, because vylog was written from a WAL thread, which > shouldn't be used for such a heavy operation as vylog recovery. > Now, we can move it to the dedicated vylog thread. This allows > us to simplify rotation logic as well: now most of work is done > from the same function (vy_log_rotate_f) executed by vylog thread, > not scattered between coio and WAL, as it used to be. Why do we need to lock out the scheduler while rotating the log in the first place? This is not anywhere in the comments, and vy_log was renamed from xctl so I got lost in the commit history. It's a pity it's not reflected in the comment. -- Konstantin Osipov, Moscow, Russia