From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 6775330655 for ; Sat, 1 Jun 2019 05:16:31 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id UTPIjFZ78m7g for ; Sat, 1 Jun 2019 05:16:31 -0400 (EDT) Received: from smtp14.mail.ru (smtp14.mail.ru [94.100.181.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 7024330659 for ; Sat, 1 Jun 2019 05:16:30 -0400 (EDT) Received: by smtp14.mail.ru with esmtpa (envelope-from ) id 1hX07o-0001XF-BH for tarantool-patches@freelists.org; Sat, 01 Jun 2019 12:16:28 +0300 Date: Sat, 1 Jun 2019 11:09:49 +0300 From: Konstantin Osipov Subject: [tarantool-patches] Re: [PATCH 00/10] vinyl: don't yield in DDL on_commit triggers Message-ID: <20190601080949.GA29429@atlas> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: tarantool-patches@freelists.org * Vladimir Davydov [19/05/17 17:54]: > DDL on_commit triggers may yield on vylog write, even though they don't > really need to wait for the transaction to be flushed to disk, as we can > recover it after restart. This blocks implementation of transactional > DDL (see #4083), because even an empty index creation may yield and > hence can't be executed transactionally along with other lightweight > operations, such as space creation. > > This patch reworks vylog implementation so that we don't need to yield > in case the vylog transaction is non-discardable (i.e. stays in the > memory buffer in case of failure). Since on_commit triggers issue only > non-discardable transactions, this makes them non-yielding, as they > should be. Given we agreed on a better fix, and you could start working on it soon (I mean really soon), I could review this patch stack as an interim solution. It contains some good changes which I don't want to go astray. Please let me know if you still need a review. Some of the comments follow on individual commits. -- Konstantin Osipov, Moscow, Russia