From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id C8773304AB for ; Fri, 31 May 2019 15:36:18 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id kuBYIr8yNIPU for ; Fri, 31 May 2019 15:36:18 -0400 (EDT) Received: from smtp55.i.mail.ru (smtp55.i.mail.ru [217.69.128.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 7C31830465 for ; Fri, 31 May 2019 15:36:18 -0400 (EDT) Date: Fri, 31 May 2019 22:36:10 +0300 From: Konstantin Osipov Subject: [tarantool-patches] Re: [PATCH v2 6/8] Offload tx_prio processing to a fiber Message-ID: <20190531193610.GE6141@atlas> References: <7ea0167cb98532c99905f74be0c07a95ead02d04.1558598679.git.georgy@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7ea0167cb98532c99905f74be0c07a95ead02d04.1558598679.git.georgy@tarantool.org> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: tarantool-patches@freelists.org Cc: Georgy Kirichenko * Georgy Kirichenko [19/05/23 11:48]: I appreciate you don't use a fiber_call() or fiber_wakeup() right from the callback, In other places we actually use fiber_wakeup(). Please see gc.c, memtx_engine.c and others. So please let's not use has_message/cond, simply wakeup the fiber in question. More comments as to why you need to run these in a fiber would not harm. -- Konstantin Osipov, Moscow, Russia