From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tarantool-patches-bounce@freelists.org>
Received: from localhost (localhost [127.0.0.1])
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 6A4332FA2F
	for <tarantool-patches@freelists.org>; Thu, 30 May 2019 07:57:48 -0400 (EDT)
Received: from turing.freelists.org ([127.0.0.1])
	by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id sCnM2wPLi7YM for <tarantool-patches@freelists.org>;
	Thu, 30 May 2019 07:57:48 -0400 (EDT)
Received: from smtp20.mail.ru (smtp20.mail.ru [94.100.179.251])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 29D2E2E28A
	for <tarantool-patches@freelists.org>; Thu, 30 May 2019 07:57:48 -0400 (EDT)
Date: Thu, 30 May 2019 14:57:44 +0300
From: Konstantin Osipov <kostja@tarantool.org>
Subject: [tarantool-patches] Re: [PATCH 1/2] schema: add "_vcollation" sysview
Message-ID: <20190530115744.GG6799@atlas>
References: <cover.1558004869.git.roman.habibov@tarantool.org>
 <5bf6f6461979b451d40925d29ff7692f979433dd.1558004869.git.roman.habibov@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <5bf6f6461979b451d40925d29ff7692f979433dd.1558004869.git.roman.habibov@tarantool.org>
Sender: tarantool-patches-bounce@freelists.org
Errors-to: tarantool-patches-bounce@freelists.org
Reply-To: tarantool-patches@freelists.org
List-Help: <mailto:ecartis@freelists.org?Subject=help>
List-Unsubscribe: <mailto:tarantool-patches-request@freelists.org?Subject=unsubscribe>
List-software: Ecartis version 1.0.0
List-Id: tarantool-patches <tarantool-patches.freelists.org>
List-Subscribe: <mailto:tarantool-patches-request@freelists.org?Subject=subscribe>
List-Owner: <mailto:>
List-post: <mailto:tarantool-patches@freelists.org>
List-Archive: <http://www.freelists.org/archives/tarantool-patches>
To: Roman Khabibov <roman.habibov@tarantool.org>
Cc: tarantool-patches@freelists.org

* Roman Khabibov <roman.habibov@tarantool.org> [19/05/16 14:27]:

> +local function upgrade_to_2_1_4()
> +    local _collation = box.space._collation
> +    local _index = box.space._index
> +
> +    -- System space format usually is in order "id, owner, name...".
> +    -- The fields "name", "owner" are swapped in "_collation" format,
> +    -- due to the field "owner" was added after the "_collation" creation.
> +    box.space._index:delete{276, 1}

why do you delete the index entry just to rename it? Can't you
update the existing record?

> +static bool
> +	vcollation_filter(struct space *source, struct tuple *tuple)
> +	{
> +		(void) source;
> +		(void) tuple;
> +		return true;
> +	}
> +

The return value and function should have the same indent, please
re-indent.

I don't see where 'PUBLIC' role is granted access to the new
space. How does this work?

-- 
Konstantin Osipov, Moscow, Russia