From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id B89E721753 for ; Wed, 29 May 2019 14:41:48 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id wZeMPJRHx1cV for ; Wed, 29 May 2019 14:41:48 -0400 (EDT) Received: from smtp36.i.mail.ru (smtp36.i.mail.ru [94.100.177.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 79C5E216E3 for ; Wed, 29 May 2019 14:41:48 -0400 (EDT) Received: by smtp36.i.mail.ru with esmtpa (envelope-from ) id 1hW3WE-0001Rr-MU for tarantool-patches@freelists.org; Wed, 29 May 2019 21:41:47 +0300 Date: Wed, 29 May 2019 21:41:45 +0300 From: Konstantin Osipov Subject: [tarantool-patches] Re: [PATCH 5/5] vinyl: lookup key in reader thread Message-ID: <20190529184145.GE6799@atlas> References: <999913620b7ef6cb0c30333d83fa7bcdfacfb955.1559142561.git.vdavydov.dev@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <999913620b7ef6cb0c30333d83fa7bcdfacfb955.1559142561.git.vdavydov.dev@gmail.com> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: tarantool-patches@freelists.org * Vladimir Davydov [19/05/29 21:03]: > If a key isn't found in the tuple cache, we fetch it from a run file. In > this case disk read and page decompression is done by a reader thread, > however key lookup in the fetched page is still performed by the tx > thread. Since pages are immutable, this could as well be done by the > reader thread, which would allow us to save some precious CPU cycles for > tx. > > Close #4257 > --- This patch is LGTM. The next logical step is moving vy_page_xrow and vy_page_stmt calls to the reader thread, but this would be more messy I guess. I'd guess they also consume quite a bit of CPU, however. -- Konstantin Osipov, Moscow, Russia