From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Wed, 29 May 2019 19:03:02 +0300 From: Vladimir Davydov Subject: Re: [PATCH v3 2/2] test: move background index build test to engine suite from vinyl Message-ID: <20190529160302.kzpgqjcymufnbcfc@esperanza> References: <87a3ff76ed05d1f42d569e162ab5125cd51b781e.1559056498.git.sergepetrenko@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87a3ff76ed05d1f42d569e162ab5125cd51b781e.1559056498.git.sergepetrenko@tarantool.org> To: Serge Petrenko Cc: tarantool-patches@freelists.org, kostja@tarantool.org List-ID: On Tue, May 28, 2019 at 06:33:25PM +0300, Serge Petrenko wrote: > +-- check that index build is aborted in case conflicting tuple is inserted > +-- error injection makes index build yield after 1 tuple is inserted into > +-- new index, check that index build is aborted if unique constraint is > +-- violated, as well as if tuple format doesn't match the new indexes one. > +box.error.injection.set('ERRINJ_BUILD_INDEX_DELAY', 0.001) Please use boolean error injection if possible, i.e. loop until it is cleared. Timeouts are very unreliable in parallel test run. Also, it looks like this test shouldn'be run in the release mode. Worth adding engine/errinj_ddl.test.lua? Also, vinyl has similar tests too, see vinyl/errinj_ddl.test.lua. It would be great if you could unify them using this new error injection you introduce.