From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Tue, 28 May 2019 12:38:25 +0300 From: Konstantin Osipov Subject: Re: [tarantool-patches] Re: [PATCH] schema: rework index sequence API Message-ID: <20190528093825.GB7254@atlas> References: <5533af44673160684c608bec811109721bef5d36.1558972156.git.vdavydov.dev@gmail.com> <20190527193846.GA7254@atlas> <20190528074112.wsu75ir4okez75as@esperanza> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190528074112.wsu75ir4okez75as@esperanza> To: Vladimir Davydov Cc: tarantool-patches@freelists.org List-ID: * Vladimir Davydov [19/05/28 10:42]: > > What happens when I rename the field using space::format()? > > Does sequence continue to work? Which field is it using then? > > I guess, just like indexes, sequences should be attached not to a field > name, but to a field no so nothing will happen when a field is renamed. > > > > > What happens when if I alter the index and modify its part names, order > > or count? The answer to this question depends on whether > > _sequence_space stores the path or the part. > > If we store fieldno+path, there will be an error altering the index > unless sequence is modified as well. I guess that's okay. > > > > > If you think using a field is a stupid idea and the core should > > continue using part no, please, test the consequences of this at > > least. Thanks. The above questions were suggestions for test cases, actually. -- Konstantin Osipov, Moscow, Russia