From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id E35A32C507 for ; Sun, 26 May 2019 05:39:32 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id XQ4SiJKFSj73 for ; Sun, 26 May 2019 05:39:32 -0400 (EDT) Received: from smtpng2.m.smailru.net (smtpng2.m.smailru.net [94.100.179.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 34D072C37A for ; Sun, 26 May 2019 05:39:32 -0400 (EDT) Date: Sun, 26 May 2019 12:39:28 +0300 From: Mergen Imeev Subject: [tarantool-patches] Re: [PATCH v1 03/21] sql: remove SQL_OK error/status code Message-ID: <20190526093928.GA20428@tarantool.org> References: <40566E8E-0F83-4137-A79F-A07D34AF0FFB@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <40566E8E-0F83-4137-A79F-A07D34AF0FFB@tarantool.org> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: "n.pettik" Cc: tarantool-patches@freelists.org Thank you for review! Mu answer and diff below. On Sat, May 25, 2019 at 05:45:12PM +0300, n.pettik wrote: > I’ve found two mentions of this macro in sqlInt.h: > in comment for sqlColumnsFromExprList() and > in comment for sql_analysis_load(). Remove > them as well. > Fixed. diff --git a/src/box/sql/sqlInt.h b/src/box/sql/sqlInt.h index c989664..958960e 100644 --- a/src/box/sql/sqlInt.h +++ b/src/box/sql/sqlInt.h @@ -3268,7 +3268,7 @@ sql_space_column_is_in_pk(struct space *space, uint32_t); * @param parse Parsing context. * @param expr_list Expr list from which to derive column names. * @param space_def Destination space definition. - * @retval sql_OK on success. + * @retval 0 on success. * @retval error codef on error. */ int sqlColumnsFromExprList(Parse *parse, ExprList *expr_list, @@ -4567,7 +4567,7 @@ sql_index_tuple_size(struct space *space, struct index *idx); * samples[] arrays. * * @param db Database handler. - * @retval sql_OK on success, smth else otherwise. + * @retval 0 on success, smth else otherwise. */ int sql_analysis_load(struct sql *db);