From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 6A8842F164 for ; Wed, 22 May 2019 15:01:37 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id smCFk6ozXeOH for ; Wed, 22 May 2019 15:01:37 -0400 (EDT) Received: from smtp16.mail.ru (smtp16.mail.ru [94.100.176.153]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 1A5DB2EF70 for ; Wed, 22 May 2019 15:01:37 -0400 (EDT) Received: by smtp16.mail.ru with esmtpa (envelope-from ) id 1hTWUZ-00061c-5i for tarantool-patches@freelists.org; Wed, 22 May 2019 22:01:35 +0300 Date: Wed, 22 May 2019 22:01:33 +0300 From: Konstantin Osipov Subject: [tarantool-patches] Re: [PATCH 2/2] tuple format: remove invalid assertion from tuple_format_iterator_next Message-ID: <20190522190133.GB22098@atlas> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: tarantool-patches@freelists.org * Vladimir Davydov [19/05/22 18:46]: > It's too early to assert msgpack type as an array when a multikey field > is encountered - we haven't checked the field type yet so the type might > as well be a map, in which case we will raise an error just a few lines > below. Remove the assertion and add a test case. I assume you pushed as obvious already, lgtm anywya. -- Konstantin Osipov, Moscow, Russia