From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Tue, 21 May 2019 16:28:14 +0300 From: Vladimir Davydov Subject: Re: [tarantool-patches] Re: [PATCH] box: fix autoincrement for json path indexes Message-ID: <20190521132814.dyn5po7rbdnqhdkk@esperanza> References: <20190515131616.tbsb7zme4oomie3h@esperanza> <8b90af23b8f527fa73cfa25e3804ef1b1d5fb6ff.1557927828.git.vdavydov.dev@gmail.com> <20190516074256.GI26670@atlas> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190516074256.GI26670@atlas> To: Konstantin Osipov Cc: tarantool-patches@freelists.org List-ID: On Thu, May 16, 2019 at 10:42:56AM +0300, Konstantin Osipov wrote: > * Vladimir Davydov [19/05/15 16:50]: > > The autoincrement code was written when there were no nested field. > > Now, it isn't enough to just skip to the autoincrement field - we also > > need to descend deeper if key_part->path is set. > > > > Note, the code expects the nested field to be present and set to NULL. > > That is, if field path is [1].a.b, the tuple must have all intermediate > > fields set: {{a = {b = box.NULL}}} (usage of box.NULL is mandatory to > > create a tuple like that in Lua). > > Please write a request to docs since this part deserves a spetial > mention in the sequences docs. Done: https://github.com/tarantool/doc/issues/782