From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 537C22F4C7 for ; Mon, 20 May 2019 11:08:43 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id q9H6mQPzrJUo for ; Mon, 20 May 2019 11:08:43 -0400 (EDT) Received: from smtpng2.m.smailru.net (smtpng2.m.smailru.net [94.100.179.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 0C0972F107 for ; Mon, 20 May 2019 11:08:42 -0400 (EDT) Date: Mon, 20 May 2019 18:08:23 +0300 From: Alexander Turenko Subject: [tarantool-patches] Re: [PATCH v2] travis-ci: fix LTO and clang Message-ID: <20190520150823.dnnumkmazd4cg5kx@tkn_work_nb> References: <75a27a279a4f307cd2cb9a4f96cb71dcdcee9201.1558099514.git.avtikhon@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <75a27a279a4f307cd2cb9a4f96cb71dcdcee9201.1558099514.git.avtikhon@tarantool.org> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: "Alexander V. Tikhonov" Cc: tarantool-patches@freelists.org Pushed to master, 2.1 and 1.10. 1.10 has no LTO targets, but I saved CMAKE_EXTRA_PARAMS to keep CI related files as similar as possible and because we possibly will need it for GitLab CI targets. I fixed minor points here and there, see below. WBR, Alexander Turenko. On Fri, May 17, 2019 at 04:25:49PM +0300, Alexander V. Tikhonov wrote: > Made fixes: > > - Added CMAKE_EXTRA_PARAMS environment to docker's container > runs to enable -DENABLE_LTO=ON/OFF cmake option. > > - Added CC/CXX environment to docker's container runs to set > clang for cmake. Also the additional environment variables > {CC,CXX}_FOR_BUILD were not postponed, because we didn't were postponed? Fixed. > run cross-compilation at the moment, for more info check: > > https://docs.travis-ci.com/user/languages/cpp/#choosing-compilers-to-test-against > > @@ -214,15 +214,17 @@ sql_value_double(sql_value * pVal) > bool > sql_value_boolean(sql_value *val) > { > - bool b; > - mem_value_bool((struct Mem *) val, &b); > + bool b = false; > + int rc = mem_value_bool((struct Mem *) val, &b); > + assert(rc == 0); > + (void) rc; We use tab symbol for indentation in C sources. Fixed. > diff --git a/src/httpc.c b/src/httpc.c > index d8ab27ef0..84bf2413c 100644 > --- a/src/httpc.c > +++ b/src/httpc.c > @@ -267,7 +267,8 @@ httpc_set_low_speed_limit(struct httpc_request *req, long low_speed_limit) > void > httpc_set_verbose(struct httpc_request *req, bool curl_verbose) > { > - curl_easy_setopt(req->curl_request.easy, CURLOPT_VERBOSE, curl_verbose); > + curl_easy_setopt(req->curl_request.easy, CURLOPT_VERBOSE, > + (long) curl_verbose); Added a whitespace to indent '(long) curl_verbose' on the same column with 'req->curl_request.easy'. > } > > void