From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gorcunov@gmail.com>
Return-Path: <gorcunov@gmail.com>
Date: Mon, 20 May 2019 16:03:05 +0300
From: Cyrill Gorcunov <gorcunov@gmail.com>
Subject: Re: [PATCH v5 1/2] slab_arena: Enhance slab_arena_create to support
 madvise hints
Message-ID: <20190520130305.GF2497@uranus.lan>
References: <20190516214559.3310-1-gorcunov@gmail.com>
 <20190516214559.3310-2-gorcunov@gmail.com>
 <20190520125538.fwvy2lj53bhvwdzj@esperanza>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20190520125538.fwvy2lj53bhvwdzj@esperanza>
To: Vladimir Davydov <vdavydov.dev@gmail.com>
Cc: tml <tarantool-patches@freelists.org>, Alexander Turenko <alexander.turenko@tarantool.org>
List-ID: <tarantool-patches.dev.tarantool.org>

On Mon, May 20, 2019 at 03:55:39PM +0300, Vladimir Davydov wrote:
> On Fri, May 17, 2019 at 12:45:58AM +0300, Cyrill Gorcunov wrote:
> > @@ -157,6 +206,9 @@ slab_arena_create(struct slab_arena *arena, struct quota *quota,
> >  	} else {
> >  		arena->arena = NULL;
> >  	}
> > +
> > +	madvise_checked(arena->arena, arena->slab_size, arena->flags);
> > +
> 
> Apparently, you should use arena->prealloc here. Fixed and pushed the
> patch set to master (both tarantool and tarantool-small).

Indeed, thanks!