From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 5697C2EDB0 for ; Sat, 18 May 2019 15:12:27 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id sZqZ68t9yfka for ; Sat, 18 May 2019 15:12:27 -0400 (EDT) Received: from smtp40.i.mail.ru (smtp40.i.mail.ru [94.100.177.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 0FCA22ED87 for ; Sat, 18 May 2019 15:12:26 -0400 (EDT) Date: Sat, 18 May 2019 22:12:24 +0300 From: Konstantin Osipov Subject: [tarantool-patches] Re: [PATCH 1/1] buffer: port static allocator to Lua Message-ID: <20190518191224.GF9448@atlas> References: <7be31fc792dac8cfee0adc221a8a22ffdf14a677.1557927101.git.v.shpilevoy@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7be31fc792dac8cfee0adc221a8a22ffdf14a677.1557927101.git.v.shpilevoy@tarantool.org> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: Vladislav Shpilevoy Cc: tarantool-patches@freelists.org * Vladislav Shpilevoy [19/05/15 16:34]: 1) scalar looks clearly as a separate patch. while I like the idea I don't appreciate the urgency and a huge patch. 2) The static alloc patch is OK to push 3) Since you care about performance so much, I don't understand why you do concat (..) in Lua static alloc. Did you check it's a compile-time, not a run-time concat? > + if ffi.C.EVP_CipherUpdate(self.ctx, wpos, scalar.ai, input, input:len()) ~= 1 then I don't understand, if you need a scalar and an array of scalars, and you have scalar and scalar_array variables, why would you ever use an array in scalar? Wouldn't it be better to have two unions instead of one for the sake of clarity? -- Konstantin Osipov, Moscow, Russia, +7 903 626 22 32