From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <kostja@tarantool.org>
Date: Thu, 16 May 2019 11:38:17 +0300
From: Konstantin Osipov <kostja@tarantool.org>
Subject: Re: [tarantool-patches] [PATCH] iproto: init coio watcher before
 join/subscribe
Message-ID: <20190516083817.GN26670@atlas>
References: <26ee4f4b5fcc01bba7fb5b33fd97983fef1ac6f0.1557952229.git.alexander.turenko@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <26ee4f4b5fcc01bba7fb5b33fd97983fef1ac6f0.1557952229.git.alexander.turenko@tarantool.org>
To: tarantool-patches@freelists.org
Cc: Vladimir Davydov <vdavydov.dev@gmail.com>, Alexander Turenko <alexander.turenko@tarantool.org>
List-ID: <tarantool-patches.dev.tarantool.org>

* Alexander Turenko <alexander.turenko@tarantool.org> [19/05/16 09:53]:
> box_process_join() and box_process_subscribe() use coio_write_xrow(),
> which calls coio_writev_timeout() under hood. If a socket will block at
> write() the function calls ev_io_start() to wake the fiber up when the
> socket will be ready to write. This code assumes that the watcher
> (struct ev_io) is initialized as coio watcher, i.e. coio_create() has
> been called.

the same comment is missing from the source code.


-- 
Konstantin Osipov, Moscow, Russia, +7 903 626 22 32