From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 6EA0E2EE2C for ; Thu, 16 May 2019 03:42:58 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id AjjaiENf21Mp for ; Thu, 16 May 2019 03:42:58 -0400 (EDT) Received: from smtp45.i.mail.ru (smtp45.i.mail.ru [94.100.177.105]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 2FB152ED69 for ; Thu, 16 May 2019 03:42:58 -0400 (EDT) Received: by smtp45.i.mail.ru with esmtpa (envelope-from ) id 1hRB2W-0002Jc-GF for tarantool-patches@freelists.org; Thu, 16 May 2019 10:42:56 +0300 Date: Thu, 16 May 2019 10:42:56 +0300 From: Konstantin Osipov Subject: [tarantool-patches] Re: [PATCH] box: fix autoincrement for json path indexes Message-ID: <20190516074256.GI26670@atlas> References: <20190515131616.tbsb7zme4oomie3h@esperanza> <8b90af23b8f527fa73cfa25e3804ef1b1d5fb6ff.1557927828.git.vdavydov.dev@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8b90af23b8f527fa73cfa25e3804ef1b1d5fb6ff.1557927828.git.vdavydov.dev@gmail.com> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: tarantool-patches@freelists.org * Vladimir Davydov [19/05/15 16:50]: > The autoincrement code was written when there were no nested field. > Now, it isn't enough to just skip to the autoincrement field - we also > need to descend deeper if key_part->path is set. > > Note, the code expects the nested field to be present and set to NULL. > That is, if field path is [1].a.b, the tuple must have all intermediate > fields set: {{a = {b = box.NULL}}} (usage of box.NULL is mandatory to > create a tuple like that in Lua). Please write a request to docs since this part deserves a spetial mention in the sequences docs. The patch itself is OK to push. -- Konstantin Osipov, Moscow, Russia, +7 903 626 22 32