From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 746202EC8C for ; Thu, 16 May 2019 03:31:42 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ISCKCvipvdPL for ; Thu, 16 May 2019 03:31:42 -0400 (EDT) Received: from smtp34.i.mail.ru (smtp34.i.mail.ru [94.100.177.94]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 2C9C62C0D1 for ; Thu, 16 May 2019 03:31:42 -0400 (EDT) Date: Thu, 16 May 2019 10:31:40 +0300 From: Konstantin Osipov Subject: [tarantool-patches] Re: [PATCH 02/10] swim: make swim_new_round() void Message-ID: <20190516073140.GE26670@atlas> References: <745abc0d14765897d4af8ba52a5a78ad229fb568.1557948687.git.v.shpilevoy@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <745abc0d14765897d4af8ba52a5a78ad229fb568.1557948687.git.v.shpilevoy@tarantool.org> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: Vladislav Shpilevoy Cc: tarantool-patches@freelists.org * Vladislav Shpilevoy [19/05/16 09:53]: > Firstly, I thought that there is an error - swim_begin_step() > does not reschedules round timer, when new_round() fails. But > then new_round() appeared never failing. This commit makes it > void to eliminate confusion. > > Probably it is a legacy since the shuffled members array was > allocated and freed in new_round(). ok to push. -- Konstantin Osipov, Moscow, Russia, +7 903 626 22 32