From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gorcunov@gmail.com>
Return-Path: <gorcunov@gmail.com>
Date: Wed, 15 May 2019 15:54:41 +0300
From: Cyrill Gorcunov <gorcunov@gmail.com>
Subject: Re: [PATCH v2] box/memtx: Allow to skip tuple memory from coredump
Message-ID: <20190515125441.GD2952@uranus.lan>
References: <20190513222053.GF2544@uranus.lan>
 <20190515124558.7k6advlhcrr5r4dt@esperanza>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20190515124558.7k6advlhcrr5r4dt@esperanza>
To: Vladimir Davydov <vdavydov.dev@gmail.com>
Cc: Alexander Turenko <alexander.turenko@tarantool.org>, tml <tarantool-patches@freelists.org>
List-ID: <tarantool-patches.dev.tarantool.org>

On Wed, May 15, 2019 at 03:45:58PM +0300, Vladimir Davydov wrote:
> 
> Please patch all places to use the new API. This better be done in a
> separate patch. Call it "Update small submodule". Then I will squash
> submodule sha update in it once we are done.
> 
> I checked - it turns out that SLAB_DONTDUMP path in madvise_checked is
> executed even if box.cfg.strip_core is false. Looks like flags aren't
> initialized properly somewhere. Please fix.
> 
> Please double-check (manually) that this new option does reduce core
> size. Try setting box.cfg.memtx_memory, writing some data to a space,
> then increasing box.cfg.memtx_memory, writing more, crashing the app,
> and checking that the core size is significantly smaller with strip_core
> set.
> 
> Also, as I mentioned in the comment to the previous patch, we should
> emit a warning in case MADV_DONTDUMP is unavailable while strip_core is
> set. This probably better be done here, in Tarantool, using say_warn.

Thanks for review! Will address.