From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gorcunov@gmail.com>
Return-Path: <gorcunov@gmail.com>
Date: Mon, 13 May 2019 15:02:37 +0300
From: Cyrill Gorcunov <gorcunov@gmail.com>
Subject: Re: [RFC v2] slab_arena: Enhance slab_arena_create to support
 madvise hints
Message-ID: <20190513120237.GE2544@uranus.lan>
References: <20190506174321.11614-1-gorcunov@gmail.com>
 <20190513100642.h3ye4sphinkcemv4@esperanza>
 <20190513103032.GB2544@uranus.lan>
 <20190513112156.zqozm26fee2ddchs@esperanza>
 <20190513114131.GD2544@uranus.lan>
 <20190513115643.26ysavw5a5izjruw@esperanza>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20190513115643.26ysavw5a5izjruw@esperanza>
To: Vladimir Davydov <vdavydov.dev@gmail.com>
Cc: tml <tarantool-patches@freelists.org>, Alexander Turenko <alexander.turenko@tarantool.org>
List-ID: <tarantool-patches.dev.tarantool.org>

On Mon, May 13, 2019 at 02:56:43PM +0300, Vladimir Davydov wrote:
> > 
> > Because we need a default value, which would be different
> > from MADV_DONTDUMP. Actually MADV_NORMAL = 0 in linux and
> 
> If SLAB_DONTDUMP isn't set, we don't need to call madvise at all, do we?

We don't, yes.

> 
> > I think we may even live without this member initialized
> 
> If we store SLAB_* flags in slab_arena instead of map_flags + madv_flags
> we won't be facing this problem, will we?

Then I think we will be able to drop it. I'll prepare a patch at
the evening and we find out.