From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 2506C1FAC9 for ; Mon, 13 May 2019 03:49:51 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id H8cKOFiCAxiD for ; Mon, 13 May 2019 03:49:51 -0400 (EDT) Received: from smtp38.i.mail.ru (smtp38.i.mail.ru [94.100.177.98]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id D20932D862 for ; Mon, 13 May 2019 03:49:50 -0400 (EDT) Date: Mon, 13 May 2019 10:49:48 +0300 From: Konstantin Osipov Subject: [tarantool-patches] Re: [PATCH v3 2/3] box: run check constraint tests on space alter Message-ID: <20190513074948.GA21594@atlas> References: <4f44a278-a591-4fbf-b2fa-8cb50200d4b0@tarantool.org> <20190507163948.GC10365@atlas> <1557251257.268416019@f459.i.mail.ru> <20190512211251.GB13210@atlas> <31454aed-131a-cc16-0408-4b91ab24ee4e@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <31454aed-131a-cc16-0408-4b91ab24ee4e@tarantool.org> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: Kirill Shcherbatov Cc: tarantool-patches@freelists.org, "n.pettik" * Kirill Shcherbatov [19/05/13 10:13]: > >> To be honest, I don’t get what Konstantin really meant in his next letter. > >> I’m ok with your approach. > > > > What is it that is unclear? > > >> It's better to fetch the bound field upon first access. > >> Most paths of the CHECK constraint may not touch most of the > >> fields. > > As far as I understand, Kostya wants something like binding on > demand for VDBE; maybe something like new op > > "OP_Fetch | struct tuple * | fieldno" = > > static inline const char * > tuple_field(struct tuple *tuple, uint32_t fieldno) > + > result cache in VDBE Correct. -- Konstantin Osipov, Moscow, Russia, +7 903 626 22 32