From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <vdavydov.dev@gmail.com>
Date: Mon, 6 May 2019 17:22:13 +0300
From: Vladimir Davydov <vdavydov.dev@gmail.com>
Subject: Re: [PATCH v5 2/4] box: introduce field_map_builder class
Message-ID: <20190506142213.bvdgyoxie3calrvn@esperanza>
References: <cover.1557142159.git.kshcherbatov@tarantool.org>
 <e0e758660b3d4597e54e79cac6c1984674fdeb9c.1557142159.git.kshcherbatov@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <e0e758660b3d4597e54e79cac6c1984674fdeb9c.1557142159.git.kshcherbatov@tarantool.org>
To: Kirill Shcherbatov <kshcherbatov@tarantool.org>
Cc: tarantool-patches@freelists.org
List-ID: <tarantool-patches.dev.tarantool.org>

On Mon, May 06, 2019 at 02:57:39PM +0300, Kirill Shcherbatov wrote:
> The new field_map_builder class encapsulates the logic associated
> with field_map allocation and initialization. In the future it
> will be extended to allocate field_map that has extensions.
> 
> Needed for #1257
> ---
>  src/box/CMakeLists.txt |   1 +
>  src/box/field_map.c    |  61 ++++++++++++++++++
>  src/box/field_map.h    | 140 +++++++++++++++++++++++++++++++++++++++++
>  src/box/memtx_engine.c |   8 +--
>  src/box/sql.c          |   5 +-
>  src/box/tuple.c        |  14 ++---
>  src/box/tuple.h        |   6 +-
>  src/box/tuple_format.c |  30 +++------
>  src/box/tuple_format.h |  12 ++--
>  src/box/vy_stmt.c      |   9 +--
>  10 files changed, 238 insertions(+), 48 deletions(-)
>  create mode 100644 src/box/field_map.c
>  create mode 100644 src/box/field_map.h

Looks good to me. I'll commit as soon as the questions with patch #1
have been resolved.