From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gorcunov@gmail.com>
Return-Path: <gorcunov@gmail.com>
Date: Mon, 6 May 2019 13:39:54 +0300
From: Cyrill Gorcunov <gorcunov@gmail.com>
Subject: Re: [PATCH 1/3] build: Check for madvise syscall
Message-ID: <20190506103954.GN2488@uranus.lan>
References: <20190501155006.14546-1-gorcunov@gmail.com>
 <20190501155006.14546-2-gorcunov@gmail.com>
 <20190506102514.4vi5kbokus4gfkgq@esperanza>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20190506102514.4vi5kbokus4gfkgq@esperanza>
To: Vladimir Davydov <vdavydov.dev@gmail.com>
Cc: tml <tarantool-patches@freelists.org>
List-ID: <tarantool-patches.dev.tarantool.org>

On Mon, May 06, 2019 at 01:25:14PM +0300, Vladimir Davydov wrote:
> On Wed, May 01, 2019 at 06:50:04PM +0300, Cyrill Gorcunov wrote:
> > Need to check if madvise is present in the system
> 
> I don't think there's much point in splitting this change in three
> patches. Please squash. OTOH it'd be nice to see how this API is
> intended to be used within Tarantool. Could you please submit the
> patch utilizing this feature in the same series?

OK, will do.

> > 
> > Part of #3509
> 
> There's no issue 3509 in tarantool/small repository. Please paste the
> full link instead - GitHub web interface knows how to show them.

OK

> >  
> > +check_function_exists(madvise TARANTOOL_SMALL_HAS_MADVISE)
> 
> I think we'd better check that MADV_DONTDUMP is available with the aid
> of check_symbol_exists.

OK