From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <vdavydov.dev@gmail.com>
Date: Thu, 2 May 2019 12:48:17 +0300
From: Vladimir Davydov <vdavydov.dev@gmail.com>
Subject: Re: [tarantool-patches] Re: [PATCH v3 7/7] Add merger for tuple
 streams (Lua part)
Message-ID: <20190502094817.4nbob2ni4czebfnq@esperanza>
References: <cover.1554906327.git.alexander.turenko@tarantool.org>
 <9af4b8f1311537ef696d71a1b09bc1721bde8ef0.1554906327.git.alexander.turenko@tarantool.org>
 <20190430173724.fgvtexkhbdutrt5x@esperanza>
 <20190430210951.GA29016@atlas>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20190430210951.GA29016@atlas>
To: Konstantin Osipov <kostja@tarantool.org>
Cc: tarantool-patches@freelists.org, Alexander Turenko <alexander.turenko@tarantool.org>
List-ID: <tarantool-patches.dev.tarantool.org>

On Wed, May 01, 2019 at 12:09:51AM +0300, Konstantin Osipov wrote:
> Vova, did you see my review for merger and key_def patches?

Yes.

> Do you agree with it?

Yes, mostly. We agreed with Alexander that it'd be better to rename
merger_source to merge_source and get rid of merger_context. Regarding
allocating a tuple in key_def.extract_key I think it's okay, because I
doubt that this function will be called often. If somebody requests it,
we can add a buffer parameter to store an extracted key as raw msgpack,
similar to how net_box.select handles it.