From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id D3DC12D851 for ; Wed, 1 May 2019 01:18:20 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id OCwLpREmVmtH for ; Wed, 1 May 2019 01:18:20 -0400 (EDT) Received: from smtp16.mail.ru (smtp16.mail.ru [94.100.176.153]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 6F0002B785 for ; Wed, 1 May 2019 01:18:20 -0400 (EDT) Date: Wed, 1 May 2019 08:18:18 +0300 From: Konstantin Osipov Subject: [tarantool-patches] Re: [PATCH 3/5] sio: return 'no host' flag from sio_uri_to_addr() Message-ID: <20190501051818.GC1139@atlas> References: <63aba61c1059b8ff4b77ed6895dca24d4efbd7ea.1556663421.git.v.shpilevoy@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <63aba61c1059b8ff4b77ed6895dca24d4efbd7ea.1556663421.git.v.shpilevoy@tarantool.org> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: Vladislav Shpilevoy Cc: tarantool-patches@freelists.org * Vladislav Shpilevoy [19/05/01 08:07]: > Results of sio_uri_to_addr("0.0.0.0:port") and > sio_uri_to_addr("port") are indistinguishable - both fill > sockaddr_in.sin_addr as INADDR_ANY. But SWIM wants to forbid the > former, and allow the latter. In case if only port is specified, > host will be 'localhost'. > > This commit returns a flag from sio_uri_to_addr() signaling if a > host was specified. I don't see how you're using the return value. What am I not understanding? -- Konstantin Osipov, Moscow, Russia, +7 903 626 22 32