From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Tue, 30 Apr 2019 21:38:55 +0300 From: Alexander Turenko Subject: Re: [PATCH v3 4/7] lua: add non-recursive msgpack decoding functions Message-ID: <20190430183855.k7iup4tp6ftwlzio@tkn_work_nb> References: <20190430130317.bgekx24eldpr45id@esperanza> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20190430130317.bgekx24eldpr45id@esperanza> To: Vladimir Davydov Cc: tarantool-patches@freelists.org List-ID: On Tue, Apr 30, 2019 at 04:03:17PM +0300, Vladimir Davydov wrote: > On Wed, Apr 10, 2019 at 06:21:22PM +0300, Alexander Turenko wrote: > > Needed for #3276. > > > > @TarantoolBot document > > Title: Non-recursive msgpack decoding functions > > > > Contracts: > > > > ``` > > msgpack.decode_array(buf.rpos, buf:size()) -> arr_len, new_rpos > > msgpack.decode_map(buf.rpos, buf:size()) -> map_len, new_rpos > > ``` > > Let's rename to decode_array_header and decode_map_header, as agreed > with Kostja. Other than that looks good to me. Done. Also updated tarantool-merger-examples repo and graphql PRs. Removed 'Consider merger's docbot comment for usage examples' from the commit message, because the patch likely will not land into master at the same time as merger. Pushed to Totktonada/gh-3276-on-board-merger.