From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <alexander.turenko@tarantool.org>
Date: Tue, 30 Apr 2019 18:07:57 +0300
From: Alexander Turenko <alexander.turenko@tarantool.org>
Subject: Re: [PATCH v3 3/7] lua: optimize creation of a tuple from a tuple
Message-ID: <20190430150756.k7pccy7kd5syvpzu@tkn_work_nb>
References: <cover.1554906327.git.alexander.turenko@tarantool.org>
 <eb8d159b6f049306a12d160e4cd334ce77ed4a14.1554906327.git.alexander.turenko@tarantool.org>
 <20190430125052.cxxu4kkphpg7lz5x@esperanza>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20190430125052.cxxu4kkphpg7lz5x@esperanza>
To: Vladimir Davydov <vdavydov.dev@gmail.com>
Cc: tarantool-patches@freelists.org
List-ID: <tarantool-patches.dev.tarantool.org>

On Tue, Apr 30, 2019 at 03:50:52PM +0300, Vladimir Davydov wrote:
> On Wed, Apr 10, 2019 at 06:21:21PM +0300, Alexander Turenko wrote:
> > Don't parse tuple data, just copy it.
> 
> I don't understand: luamp_encode_tuple doesn't parse or decode a tuple.
> It simply copies it to the stream. This patch simply eliminates an extra
> memcpy, right?
> 
> Is this small optimization worth complicating the code?

I did thought that it parses a tuple. Now I see that it does not.

Dropped from the patchset.

WBR, Alexander Turenko.