From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 18AA02B955 for ; Mon, 29 Apr 2019 08:25:30 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 9goldRHrJD51 for ; Mon, 29 Apr 2019 08:25:30 -0400 (EDT) Received: from smtp52.i.mail.ru (smtp52.i.mail.ru [94.100.177.112]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id C8C822A886 for ; Mon, 29 Apr 2019 08:25:29 -0400 (EDT) Received: by smtp52.i.mail.ru with esmtpa (envelope-from ) id 1hL5Lc-00012U-5b for tarantool-patches@freelists.org; Mon, 29 Apr 2019 15:25:28 +0300 Date: Mon, 29 Apr 2019 15:25:28 +0300 From: Konstantin Osipov Subject: [tarantool-patches] Re: [PATCH 3/3] crypto: implement crypto codec API and AES 128 encryption Message-ID: <20190429122528.GC25624@atlas> References: <0e95f1eff6e2caaab4a2ed344bfdf9e67a9f23b5.1556226152.git.v.shpilevoy@tarantool.org> <72a8abe6-39fb-7ec1-1abf-5ba9cf13ee6c@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <72a8abe6-39fb-7ec1-1abf-5ba9cf13ee6c@tarantool.org> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: tarantool-patches@freelists.org * Vladislav Shpilevoy [19/04/29 14:09]: > I've decided that the patch is too raw and reworked it a bit. > I force pushed my changed resent the whole patchset in a new > thread as V2. > > Main change is addition of a second encryption algorithm - None. > It is needed because SWIM has encryption API like > > swim_set_codec(enum crypto_algo algo, const char *key); > > And I need a way how to disable encryption after its enabling. > It can be done now via > > swim_set_codec(CRYPTO_NONE, NULLL); > > > Secondly, I renamed 'encode/decode' to 'encrypt/decrypt' in > all methods and tests. > > Thirdly, I removed hardcoded block sizes from encrypt() method. All of the above is good stuff. -- Konstantin Osipov, Moscow, Russia, +7 903 626 22 32