From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 88FEB2B598 for ; Thu, 25 Apr 2019 07:15:59 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id O43Y_nb9-2x9 for ; Thu, 25 Apr 2019 07:15:59 -0400 (EDT) Received: from mail-lf1-f67.google.com (mail-lf1-f67.google.com [209.85.167.67]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 3B8C22A474 for ; Thu, 25 Apr 2019 07:15:59 -0400 (EDT) Received: by mail-lf1-f67.google.com with SMTP id u17so17205210lfi.3 for ; Thu, 25 Apr 2019 04:15:59 -0700 (PDT) Date: Thu, 25 Apr 2019 14:15:56 +0300 From: Konstantin Osipov Subject: [tarantool-patches] Re: [PATCH v1 1/1] sql: invalid integer type in arithmetic operations Message-ID: <20190425111556.GL29257@atlas> References: <72941eba60647c98f4559cbd0c862bade990d761.1556120090.git.kshcherbatov@tarantool.org> <0929e575-2d28-7cd0-36bc-0a1bf1af76fe@tarantool.org> <04E0C86F-84E5-400F-ACE0-80FD6799E4E3@tarantool.org> <20190425104956.GI29257@atlas> <20190425105237.GA2297@atlas> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: Kirill Shcherbatov Cc: tarantool-patches@freelists.org, Vladislav Shpilevoy * Kirill Shcherbatov [19/04/25 14:12]: > Exactly this logic is already on master branch (but only with few sequential ifs, not a table). Please do a table. You already have a branching hell, and UNSIGNED arithmetics is raising questions. In particular, I disagree that unsigned + unsigned should give you number - it should give you unsigned. -- Konstantin Osipov, Moscow, Russia, +7 903 626 22 32 http://tarantool.io - www.twitter.com/kostja_osipov