From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 40CAA2C95F for ; Thu, 25 Apr 2019 06:53:17 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id NXz-Bi57UItF for ; Thu, 25 Apr 2019 06:53:17 -0400 (EDT) Received: from smtp49.i.mail.ru (smtp49.i.mail.ru [94.100.177.109]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 00FCB25CCC for ; Thu, 25 Apr 2019 06:53:16 -0400 (EDT) Received: by smtp49.i.mail.ru with esmtpa (envelope-from ) id 1hJc0B-0004Nc-AW for tarantool-patches@freelists.org; Thu, 25 Apr 2019 13:53:15 +0300 Date: Thu, 25 Apr 2019 13:53:15 +0300 From: Konstantin Osipov Subject: [tarantool-patches] Re: [PATCH 1/1] swim: optimize memory layout of struct swim_member Message-ID: <20190425105315.GJ29257@atlas> References: <1aa402d982fd6b8da46abfba78196c94f455ecbd.1556136325.git.v.shpilevoy@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1aa402d982fd6b8da46abfba78196c94f455ecbd.1556136325.git.v.shpilevoy@tarantool.org> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: tarantool-patches@freelists.org * Vladislav Shpilevoy [19/04/25 00:46]: > Struct swim_member describes attributes of one remote member of > a SWIM cluster. It is relatively often accessed. And it has two > huge structures - struct swim_packet ping/ack_task. Each is 1500 > bytes. When these tasks are in the middle of the structure, they > split and spoil cache lines. > > This patch moves the whole failure detection attribute family to > the bottom of the structure, and moves these two tasks to the > end of layout. > --- OK to push. -- Konstantin Osipov, Moscow, Russia, +7 903 626 22 32 http://tarantool.io - www.twitter.com/kostja_osipov