From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 1C94B2C69D for ; Thu, 25 Apr 2019 06:29:58 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id rRCh3K9Lv8Nz for ; Thu, 25 Apr 2019 06:29:58 -0400 (EDT) Received: from smtp52.i.mail.ru (smtp52.i.mail.ru [94.100.177.112]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 754DC2C69C for ; Thu, 25 Apr 2019 06:29:57 -0400 (EDT) Date: Thu, 25 Apr 2019 13:29:54 +0300 From: Kirill Yukhin Subject: [tarantool-patches] Re: [PATCH v1 1/1] tap: fix is_deeply box.NULL corner cases Message-ID: <20190425102954.2inesnf6knzvgicb@tarantool.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: tarantool-patches@freelists.org Cc: v.shpilevoy@tarantool.org, Kirill Shcherbatov Hello, On 23 Apr 15:55, Kirill Shcherbatov wrote: > The tap:is_deeply call used to return inconsistent result > processing an empty tuple and tuple that has no values: > is_deeply({a = box.NULL}, {}) == true > is_deeply({}, {a = box.NULL}) == false > Fixed to return true in such case. > > We shouldn't return false in such case because of marshaling > features covered by tests: > is_deeply(decode(encode(t)), t) must be true for all t, > including t = nil; decode(encode(nil)) == box.NULL. > > Closes #4125 > --- > Branch: http://github.com/tarantool/tarantool/tree/kshch/gh-4125-inconsistent-isdeeply-results > Issue: https://github.com/tarantool/tarantool/issues/4125 I've checked your patch into master and 2.1 branch. -- Regards, Kirill Yukhin