From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id D75462BC53 for ; Wed, 24 Apr 2019 15:19:54 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id uHINWcBLhMM1 for ; Wed, 24 Apr 2019 15:19:54 -0400 (EDT) Received: from mail-lj1-f171.google.com (mail-lj1-f171.google.com [209.85.208.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 7110F2BAF5 for ; Wed, 24 Apr 2019 15:19:54 -0400 (EDT) Received: by mail-lj1-f171.google.com with SMTP id h21so17947067ljk.13 for ; Wed, 24 Apr 2019 12:19:54 -0700 (PDT) Date: Wed, 24 Apr 2019 22:19:51 +0300 From: Konstantin Osipov Subject: [tarantool-patches] Re: [PATCH 09/10] Enable asyncronous wal writes Message-ID: <20190424191951.GI21344@atlas> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: tarantool-patches@freelists.org Cc: Georgy Kirichenko * Georgy Kirichenko [19/04/19 20:00]: > Allow to send a journal entry to wal without wait until the writing > was finished. Two methods were introduced: > * async_write method emits an entry to be written, returns 0 if the > entry was successfully scheduled; > * async_wait method waits until writing was finished and returns a > result of journal write. > The approach is looking good, I may have a few nits about the api (will send them in a second review, separately). -- Konstantin Osipov, Moscow, Russia, +7 903 626 22 32 http://tarantool.io - www.twitter.com/kostja_osipov