From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 913A12BB03 for ; Wed, 24 Apr 2019 15:17:04 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Xk3Vecyvysge for ; Wed, 24 Apr 2019 15:17:04 -0400 (EDT) Received: from mail-lj1-f170.google.com (mail-lj1-f170.google.com [209.85.208.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 452A629329 for ; Wed, 24 Apr 2019 15:17:04 -0400 (EDT) Received: by mail-lj1-f170.google.com with SMTP id q66so17962803ljq.7 for ; Wed, 24 Apr 2019 12:17:04 -0700 (PDT) Date: Wed, 24 Apr 2019 22:16:56 +0300 From: Konstantin Osipov Subject: [tarantool-patches] Re: [PATCH 07/10] Remove fiber from a journal_entry structure Message-ID: <20190424191656.GG21344@atlas> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: tarantool-patches@freelists.org Cc: Georgy Kirichenko * Georgy Kirichenko [19/04/19 20:00]: > Use a trigger to handle journal entry write done event. This relaxes > friction between fiber and transaction life cycles. I think the idea of journal entry triggers is great, but I also think it's a bit of an overkill to always initialize triggers and run all fibers through the cond. Would be ideal if we keep using simple journal_entry objects for most cases and use journal_entry with triggers only when we need these triggers. Would that be possible to do? We could keep the trigger-related members in journal_entry class, only initialize and use them strictly when needed, or we could make a derived structure which contains the trigger state and actions. -- Konstantin Osipov, Moscow, Russia, +7 903 626 22 32 http://tarantool.io - www.twitter.com/kostja_osipov