From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 77CC02C29D for ; Wed, 24 Apr 2019 12:37:54 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 0lXVe5G8iDMz for ; Wed, 24 Apr 2019 12:37:54 -0400 (EDT) Received: from smtp5.mail.ru (smtp5.mail.ru [94.100.179.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 34F682BDBB for ; Wed, 24 Apr 2019 12:37:54 -0400 (EDT) Date: Wed, 24 Apr 2019 19:37:50 +0300 From: Konstantin Osipov Subject: [tarantool-patches] Re: [PATCH 2/6] test: remove swim packet filter destructors Message-ID: <20190424163750.GB13687@atlas> References: <483a32cd0f1e92a2163ed4875cd9ca2fb450fa3d.1556116199.git.v.shpilevoy@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <483a32cd0f1e92a2163ed4875cd9ca2fb450fa3d.1556116199.git.v.shpilevoy@tarantool.org> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: Vladislav Shpilevoy Cc: tarantool-patches@freelists.org * Vladislav Shpilevoy [19/04/24 18:50]: > Swim test packet filters are supposed to filter out packets > matching certain criteria or with a probability. They were > implemented as a filter-function and userdata passed into the > former on each invocation. Usually it was allocated on heap and > needed deletion. But it appeared that much simpler is to store > the filters inside struct swim_node, pass it as userdata, and get > rid of userdata destructors and dynamic allocations. > > The patch is motivated by necessity to add one new filter, which > anyway will need struct swim_node as userdata. OK to push. -- Konstantin Osipov, Moscow, Russia, +7 903 626 22 32 http://tarantool.io - www.twitter.com/kostja_osipov