From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tarantool-patches-bounce@freelists.org>
Received: from localhost (localhost [127.0.0.1])
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id E81EB2BF99
	for <tarantool-patches@freelists.org>; Wed, 24 Apr 2019 07:57:28 -0400 (EDT)
Received: from turing.freelists.org ([127.0.0.1])
	by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id ntwpvarAZjg2 for <tarantool-patches@freelists.org>;
	Wed, 24 Apr 2019 07:57:28 -0400 (EDT)
Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 3CBC72BF1F
	for <tarantool-patches@freelists.org>; Wed, 24 Apr 2019 07:57:28 -0400 (EDT)
Date: Wed, 24 Apr 2019 14:57:16 +0300
From: Alexander Turenko <alexander.turenko@tarantool.org>
Subject: [tarantool-patches] Re: [PATCH v2 1/1] tap: fix is_deeply box.NULL
 corner cases
Message-ID: <20190424115713.dg5oqqyarg4fvich@tkn_work_nb>
References: <b6785b2cba8a866bf3574efad039a4c47cf51798.1556024070.git.kshcherbatov@tarantool.org>
 <140e8187-8f84-c89d-10d8-57891e8f9353@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <140e8187-8f84-c89d-10d8-57891e8f9353@tarantool.org>
Sender: tarantool-patches-bounce@freelists.org
Errors-to: tarantool-patches-bounce@freelists.org
Reply-To: tarantool-patches@freelists.org
List-Help: <mailto:ecartis@freelists.org?Subject=help>
List-Unsubscribe: <mailto:tarantool-patches-request@freelists.org?Subject=unsubscribe>
List-software: Ecartis version 1.0.0
List-Id: tarantool-patches <tarantool-patches.freelists.org>
List-Subscribe: <mailto:tarantool-patches-request@freelists.org?Subject=subscribe>
List-Owner: <mailto:>
List-post: <mailto:tarantool-patches@freelists.org>
List-Archive: <http://www.freelists.org/archives/tarantool-patches>
To: tarantool-patches@freelists.org, Kirill Shcherbatov <kshcherbatov@tarantool.org>
Cc: v.shpilevoy@tarantool.org

> @@ -163,6 +173,7 @@ local function is_deeply(test, got, expected, message, extra)
>      extra = extra or {}
>      extra.got = got
>      extra.expected = expected
> +    extra.strict = test.strict

The 'extra' parameter is needed to provide a user more information in
case of a fail. Here we use it to push options for cmpdeeply(). I would
add 'opts' parameter instead.