From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 2E8852A1D2 for ; Tue, 23 Apr 2019 06:24:46 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id JVis8Mt3a9-J for ; Tue, 23 Apr 2019 06:24:46 -0400 (EDT) Received: from smtp14.mail.ru (smtp14.mail.ru [94.100.181.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id D99B925112 for ; Tue, 23 Apr 2019 06:24:45 -0400 (EDT) Date: Tue, 23 Apr 2019 13:24:43 +0300 From: Kirill Yukhin Subject: [tarantool-patches] Re: [PATCH 1/1] sql: drop a useless check from lookupName() Message-ID: <20190423102443.hbqaforngk7re7mp@tarantool.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: Vladislav Shpilevoy Cc: tarantool-patches@freelists.org Hello, On 22 Apr 21:34, Vladislav Shpilevoy wrote: > There was a variable used as a counter from 0 to > uint32_t space_def->field_count. Obviously it can't be < 0, but > there was a check for that. Drop it. > > The check was revealed during SQL BOOLEAN review, where one of > patches gets rid of some explicit Expr.type assignments. > --- > Branch: https://github.com/tarantool/tarantool/tree/gerold103/drop-useless-check-from-resolve I've checked your patch into master. -- Regards, Kirill Yukhin