From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 946542C526 for ; Thu, 18 Apr 2019 14:20:22 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id uaIPZJ8BzYLW for ; Thu, 18 Apr 2019 14:20:22 -0400 (EDT) Received: from smtp55.i.mail.ru (smtp55.i.mail.ru [217.69.128.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 46C982C503 for ; Thu, 18 Apr 2019 14:20:22 -0400 (EDT) Received: by smtp55.i.mail.ru with esmtpa (envelope-from ) id 1hHBe0-0004Gu-34 for tarantool-patches@freelists.org; Thu, 18 Apr 2019 21:20:20 +0300 Date: Thu, 18 Apr 2019 21:20:19 +0300 From: Konstantin Osipov Subject: [tarantool-patches] Re: [PATCH 7/6] swim: drop incarnation_inc parameter from update() routines Message-ID: <20190418182019.GA26665@chai> References: <2e76a679-c509-f12e-5abb-b1457ca478b0@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2e76a679-c509-f12e-5abb-b1457ca478b0@tarantool.org> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: tarantool-patches@freelists.org * Vladislav Shpilevoy [19/04/18 21:18]: > Update_addr and update_payload need to increment member's > incarnation when it is self. For that they used a special > parameter incarnation_inc set in 1 for self and in 0 for others. > > It was used to encapsulate incarnation update + event scheduling > on member attribute updates, but on the other hand it broke > another encapsulation level - there should not be exceptions for > 'self' in these functions. > > This patch makes incarnation increment explicit in the places > where 'self' is updated. ok to push -- Konstantin Osipov, Moscow, Russia, +7 903 626 22 32 http://tarantool.io - www.twitter.com/kostja_osipov