From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 7CC492AA87 for ; Thu, 18 Apr 2019 13:24:06 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 8WIiUceAVZN7 for ; Thu, 18 Apr 2019 13:24:06 -0400 (EDT) Received: from smtp56.i.mail.ru (smtp56.i.mail.ru [217.69.128.36]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 38B752AA86 for ; Thu, 18 Apr 2019 13:24:06 -0400 (EDT) Received: by smtp56.i.mail.ru with esmtpa (envelope-from ) id 1hHAlY-0000oS-Hl for tarantool-patches@freelists.org; Thu, 18 Apr 2019 20:24:04 +0300 Date: Thu, 18 Apr 2019 20:24:04 +0300 From: Konstantin Osipov Subject: [tarantool-patches] Re: [PATCH] memtx: cancel checkpoint thread at exit Message-ID: <20190418172404.GG13022@chai> References: <8278bbd0a73bbd0e18a4e8633eb0ad71f2ffa3f7.1555601315.git.vdavydov.dev@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8278bbd0a73bbd0e18a4e8633eb0ad71f2ffa3f7.1555601315.git.vdavydov.dev@gmail.com> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: tarantool-patches@freelists.org * Vladimir Davydov [19/04/18 18:47]: > If a tarantool instance exits while checkpointing is in progress, the > memtx checkpoint thread, which writes the snap file, can access already > freed data resulting in a crash. Let's fix this the same way we did for > relay and vinyl threads - simply cancel the thread forcefully and wait > for it to terminate. OK to push. -- Konstantin Osipov, Moscow, Russia, +7 903 626 22 32 http://tarantool.io - www.twitter.com/kostja_osipov