From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id DB5A62C1AB for ; Thu, 18 Apr 2019 11:17:20 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id u8OPAq-a7Y30 for ; Thu, 18 Apr 2019 11:17:20 -0400 (EDT) Received: from smtp50.i.mail.ru (smtp50.i.mail.ru [94.100.177.110]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 994D82BC3C for ; Thu, 18 Apr 2019 11:17:20 -0400 (EDT) Received: by smtp50.i.mail.ru with esmtpa (envelope-from ) id 1hH8ms-0000bg-RP for tarantool-patches@freelists.org; Thu, 18 Apr 2019 18:17:19 +0300 Date: Thu, 18 Apr 2019 18:17:18 +0300 From: Konstantin Osipov Subject: [tarantool-patches] Re: [PATCH 2/4] swim: extract binary ip/port into a separate struct Message-ID: <20190418151718.GD13022@chai> References: <86e84b69ecdd3ddd8e8abcb0f0b3818ba8d73d86.1555530516.git.v.shpilevoy@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <86e84b69ecdd3ddd8e8abcb0f0b3818ba8d73d86.1555530516.git.v.shpilevoy@tarantool.org> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: tarantool-patches@freelists.org * Vladislav Shpilevoy [19/04/18 09:03]: > At this moment there are two binary structures in the SWIM > protocol carrying an address: swim_member_passport and > swim_meta_header_bin - one address in each. This code duplication > was not formidable enough to stimulate creation of a separate > address structure. > > But forthcoming indirect messages protocol extensions will add 2 > new cases of encoding a binary address. It triggered this patch > to reduce code duplication. > OK to push. -- Konstantin Osipov, Moscow, Russia, +7 903 626 22 32 http://tarantool.io - www.twitter.com/kostja_osipov