From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 807712B24A for ; Thu, 18 Apr 2019 09:25:25 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 3kcmvZ04-49B for ; Thu, 18 Apr 2019 09:25:25 -0400 (EDT) Received: from smtp49.i.mail.ru (smtp49.i.mail.ru [94.100.177.109]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id CE07A2B095 for ; Thu, 18 Apr 2019 09:25:24 -0400 (EDT) Date: Thu, 18 Apr 2019 16:25:22 +0300 From: Kirill Yukhin Subject: [tarantool-patches] Re: [PATCH] Set format for spaces with sysview engine Message-ID: <20190418132522.cfpocghcjmjtcpe3@tarantool.org> References: <265af30c-727f-e781-e2c3-4bc13c98eeae@tarantool.org> <20190417081320.xwcf3ogkvrspgdu3@tarantool.org> <68ec9d10-4fa6-4997-54bd-4a80b1ca79ce@tarantool.org> <20190418081630.yfe5hi7w2m3bu5lh@tarantool.org> <77d5c2c1-8a26-990c-0fc0-dc40d56f64ae@tarantool.org> <20190418111411.hl4okehi6adv6pvi@tarantool.org> <20190418120840.667b7m5iqtjl2r42@tarantool.org> <5783e513-19e4-182b-941b-9070a7266c92@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <5783e513-19e4-182b-941b-9070a7266c92@tarantool.org> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: Vladislav Shpilevoy Cc: tarantool-patches@freelists.org Hello, On 18 апр 15:43, Vladislav Shpilevoy wrote: > Now finally technically is ok except that I will never agree > with the test-file-per-issue policy. It is ridiculous. Thanks, I'll check it into master and 2.1 branches. > Following this logic I should name the whole swim subsystem > test file like gh-3234-swim and rename the binary protocol > test file into gh-3234-swim_proto - two files about the same > issue with an ugly prefix looking like it is a fix of a bug. I hope that will be part of SOP soon. > Additionally, creation of a new file on each typo-like issue > will lead us sometime into the test-hell like it was in SQLite: > > tkt-02a8e81d44.test tkt-54844eea3f.test tkt-9a8b09f8e6.test tkt-d82e3f3721.test tkt1514.test tkt2450.test tkt3121.test tkt3541.test tkt3838.test > tkt-26ff0c2d1e.test tkt-5d863f876e.test tkt-9d68c883.test tkt-f3e5abed55.test tkt1536.test tkt2565.test tkt3201.test tkt3554.test tkt3841.test > tkt-2a5629202f.test tkt-5e10420e8d.test tkt-9f2eb3abac.test tkt-f67b41381a.test tkt1537.test tkt2640.test tkt3292.test tkt3581.test tkt3871.test > tkt-2d1a5c67d.test tkt-5ee23731f.test tkt-a7b7803e.test tkt-f777251dc7a.test tkt1567.test tkt2643.test tkt3298.test tkt35xx.test tkt3879.test > tkt-2ea2425d34.test tkt-6bfb98dfc0.test tkt-a8a0d2996a.test tkt-f7b4edec.test tkt1644.test tkt2686.test tkt3334.test tkt3630.test tkt3911.test > tkt-31338dca7e.test tkt-752e1646fc.test tkt-b1d3a2e531.test tkt-f973c7ac31.test tkt1667.test tkt2767.test tkt3346.test tkt3718.test tkt3918.test > tkt-313723c356.test tkt-78e04e52ea.test tkt-b351d95f9.test tkt-fa7bf5ec.test tkt1873.test tkt2817.test tkt3357.test tkt3731.test tkt3922.test > tkt-385a5b56b9.test tkt-7a31705a7e6.test tkt-b72787b1.test tkt-fc62af4523.test tkt2141.test tkt2820.test tkt3419.test tkt3757.test tkt3929.test How ofter do you scan list of regression tests? I bet - never. But you very often try to extract 2-3 lines of failed case. In case of aggregated testcases this might take a while. Also, please keep in mind that number of cores are increasing on this planet. So, we are trying to get some profit: more files -> more processes -> more cores utilized. Finally, filename should be accompanied w/ 2-3 key words, IMHO. This will significantly increase readability of such strange listings. -- Regards, Kirill Yukhin