From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id B39FD2C2CC for ; Thu, 18 Apr 2019 08:08:43 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id YaEkYsXk4TKx for ; Thu, 18 Apr 2019 08:08:43 -0400 (EDT) Received: from smtp51.i.mail.ru (smtp51.i.mail.ru [94.100.177.111]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id F3E7C2C2CB for ; Thu, 18 Apr 2019 08:08:42 -0400 (EDT) Date: Thu, 18 Apr 2019 15:08:40 +0300 From: Kirill Yukhin Subject: [tarantool-patches] Re: [PATCH] Set format for spaces with sysview engine Message-ID: <20190418120840.667b7m5iqtjl2r42@tarantool.org> References: <265af30c-727f-e781-e2c3-4bc13c98eeae@tarantool.org> <20190417081320.xwcf3ogkvrspgdu3@tarantool.org> <68ec9d10-4fa6-4997-54bd-4a80b1ca79ce@tarantool.org> <20190418081630.yfe5hi7w2m3bu5lh@tarantool.org> <77d5c2c1-8a26-990c-0fc0-dc40d56f64ae@tarantool.org> <20190418111411.hl4okehi6adv6pvi@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: Vladislav Shpilevoy Cc: tarantool-patches@freelists.org Hello, On 18 апр 14:39, Vladislav Shpilevoy wrote: > > > On 18/04/2019 14:14, Kirill Yukhin wrote: > > Hello, > > > > On 18 апр 13:43, Vladislav Shpilevoy wrote: > >> Hi! Thanks for the fixes! See 4 comments below. > >> > >> 1. Now I see that sysview tuple format leaks. Please, > >> apply this diff: > >> > >> ====================================================== > >> diff --git a/src/box/sysview.c b/src/box/sysview.c > >> index 0b07c9f4a..96c5e78ca 100644 > >> --- a/src/box/sysview.c > >> +++ b/src/box/sysview.c > >> @@ -545,6 +545,8 @@ sysview_engine_create_space(struct engine *engine, struct space_def *def, > >> free(space); > >> return NULL; > >> } > >> + /* Format is now referenced by the space. */ > >> + tuple_format_unref(format); > >> return space; > >> } > >> ====================================================== > > > > Done. > > > > Branch force-pushed and re-tested. > > How was it retested? I didn't staged updated result. Done. -- Regards, Kirill Yukhin