From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <alexander.turenko@tarantool.org>
Date: Fri, 12 Apr 2019 23:37:49 +0300
From: Alexander Turenko <alexander.turenko@tarantool.org>
Subject: Re: [tarantool-patches] [PATCH] Improve box.stat.net output
Message-ID: <20190412203749.i53awcaw4s3cvo5d@tkn_work_nb>
References: <8bd85fabecbbc5ec987327e91506ee89e4f6e985.1555092935.git.vdavydov.dev@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <8bd85fabecbbc5ec987327e91506ee89e4f6e985.1555092935.git.vdavydov.dev@gmail.com>
To: Vladimir Davydov <vdavydov.dev@gmail.com>
Cc: tarantool-patches@freelists.org
List-ID: <tarantool-patches.dev.tarantool.org>

Just remind: I would add docbot comment.

WBR, Alexander Turenko.

On Fri, Apr 12, 2019 at 09:17:29PM +0300, Vladimir Davydov wrote:
>  - Add REQUESTS.current to report the number of requests currently in
>    flight, because it's useful for understanding whether we need to
>    increase box.cfg.net_msg_max.
>  - Add REQUESTS.{rps,total}, because knowing the number of requests
>    processed per second can come in handy for performance analysis.
>  - Add CONNECTIONS.{rps,total} that show the number of connections
>    opened per second and total. Those are not really necessary, but
>    without them the output looks kinda lopsided.
> 
> Now the output looks like this:
> 
>  | ---
>  | - SENT:
>  |     total: 5344924
>  |     rps: 840212
>  |   CONNECTIONS:
>  |     current: 60
>  |     rps: 148
>  |     total: 949
>  |   REQUESTS:
>  |     current: 17
>  |     rps: 1936
>  |     total: 12139
>  |   RECEIVED:
>  |     total: 240882
>  |     rps: 38428
>  | ...
> 
> Closes #4150
> ---
> https://github.com/tarantool/tarantool/issues/4150
> https://github.com/tarantool/tarantool/commits/dv/gh-4150-improve-net-stat