From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gorcunov@gmail.com>
Return-Path: <gorcunov@gmail.com>
Date: Fri, 12 Apr 2019 17:59:25 +0300
From: Cyrill Gorcunov <gorcunov@gmail.com>
Subject: Re: [PATCH] lib/core/coio_file: Use eio_sendfile_sync instead of a
 chunk mode
Message-ID: <20190412145925.GD20557@uranus>
References: <20190410193624.12510-1-gorcunov@gmail.com>
 <20190412134323.ebqjjxaqgpbu4dt5@esperanza>
 <20190412140558.GB20557@uranus>
 <20190412141916.janpwwy27epsfbfv@esperanza>
 <20190412144212.GC20557@uranus>
 <20190412145347.sl3m5zynsg5sujg5@esperanza>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20190412145347.sl3m5zynsg5sujg5@esperanza>
To: Vladimir Davydov <vdavydov.dev@gmail.com>
Cc: tml <tarantool-patches@freelists.org>
List-ID: <tarantool-patches.dev.tarantool.org>

On Fri, Apr 12, 2019 at 05:53:47PM +0300, Vladimir Davydov wrote:
> 
> True, I don't think it's worth testing it.
> 
> I just wanted to say that we need to make sure it works - check it
> manually and I will too.

Current tests are passed even without "cycled sendfile" simply
because current tests are not operating with huge files (i ran
them manually before sending the patch). I'll recheck everything
once again before sending v2. Thanks for review!

> Alternatively, we could add an error injection, reducing the sendfile
> copy size, but I think it's not really necessary.

OK