From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tarantool-patches-bounce@freelists.org>
Received: from localhost (localhost [127.0.0.1])
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 4D7D32C78A
	for <tarantool-patches@freelists.org>; Fri, 12 Apr 2019 10:17:27 -0400 (EDT)
Received: from turing.freelists.org ([127.0.0.1])
	by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id Nk8uLQLwF-hz for <tarantool-patches@freelists.org>;
	Fri, 12 Apr 2019 10:17:27 -0400 (EDT)
Received: from smtp32.i.mail.ru (smtp32.i.mail.ru [94.100.177.92])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id EF90B2C779
	for <tarantool-patches@freelists.org>; Fri, 12 Apr 2019 10:17:26 -0400 (EDT)
Date: Fri, 12 Apr 2019 17:17:24 +0300
From: Kirill Yukhin <kyukhin@tarantool.org>
Subject: [tarantool-patches] Re: [PATCH] sql: increment rowcount of FK
 alteration
Message-ID: <20190412141724.zfuzwzuerqimt5ps@tarantool.org>
References: <20190410132715.81284-1-korablev@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20190410132715.81284-1-korablev@tarantool.org>
Sender: tarantool-patches-bounce@freelists.org
Errors-to: tarantool-patches-bounce@freelists.org
Reply-To: tarantool-patches@freelists.org
List-Help: <mailto:ecartis@freelists.org?Subject=help>
List-Unsubscribe: <mailto:tarantool-patches-request@freelists.org?Subject=unsubscribe>
List-software: Ecartis version 1.0.0
List-Id: tarantool-patches <tarantool-patches.freelists.org>
List-Subscribe: <mailto:tarantool-patches-request@freelists.org?Subject=subscribe>
List-Owner: <mailto:>
List-post: <mailto:tarantool-patches@freelists.org>
List-Archive: <http://www.freelists.org/archives/tarantool-patches>
To: tarantool-patches@freelists.org
Cc: v.shpilevoy@tarantool.org, Nikita Pettik <korablev@tarantool.org>

Hello,

On 10 апр 16:27, Nikita Pettik wrote:
> Before this patch SQL statement which involves FK constraints creation
> or drop didn't increment rowcount:
> 
> box.execute("ALTER TABLE t ADD CONSTRAINT fk1 FOREIGN KEY (b) REFERENCES parent (a);")
> ---
> - rowcount: 0
> ...
> 
> This patch fixes this misbehaviour: accidentally VDBE was forgotten to
> enable counting changes during ALTER TABLE ADD/DROP constraint.
> 
> Closes #4130
> ---
> Branch: https://github.com/tarantool/tarantool/issues/4130
> Issue: https://github.com/tarantool/tarantool/tree/np/gh-4130-increment-row-count-on-fk-alteration

I've checked your patch into master & 2.1 branch.

--
Regards, Kirill Yukhin