From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Thu, 11 Apr 2019 23:12:19 +0300 From: Vladimir Davydov Subject: Re: [PATCH] vinyl: take into account primary key lookup in latency accounting Message-ID: <20190411201218.nmfdpxpncb5ro52l@esperanza> References: <20190411200434.GB25603@chai> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190411200434.GB25603@chai> To: Konstantin Osipov Cc: tarantool-patches@freelists.org List-ID: On Thu, Apr 11, 2019 at 11:04:34PM +0300, Konstantin Osipov wrote: > * Vladimir Davydov [19/04/11 20:29]: > > Currently, latency accounting and warning lives in vy_point_lookup and > > vy_read_iterator_next. As a result, we don't take into account full by > > partial tuple lookup in it while it can take quite a while, especially > > if there are lots of deferred DELETE statements we have to skip. So this > > patch moves latency accounting to the upper level, namely to vy_get and > > vinyl_iterator_{primary,secondary}_next. > > I believe this si a temporary patch as long as it uses > clock_monotonic :) It doesn't. I just moves latency accounting to the upper level to take into account the time spent on skipping deferred DELETEs. It still uses ev_monotonic_now for latency accounting.